Akopia Akopia Services

[Date Prev][Date Next][Thread Prev][Thread Next][Minivend by date ][Minivend by thread ]

[mv] 4.03 Order profile check misbehaviour?



******    message to minivend-users from "Ton Verhagen" <ton@verhagen.net>     ******

Hi Minivendors,

I noticed that the first check after a &fatal=yes in an order
profile will still be evaluated even if there are failures in
previous checks. I mean:

__NAME__ my_order_profile
field1=required
field2=required
field3=required
&fatal=yes
field2=email
field4=phone
__END__

If one or more checks (field1, field2 or field3) fail than MV
will still evaluate the check field2=email before returning to
mv_nexpage (mv_failpage).

I would prefer that MV return immediately when encountering a
&fatal=yes pragma if there are failed checks. Probably that is
the intended behaviour, is it?

This patch of Order.pm makes sure MV will return right after
&fatal=yes if there are errors.

1047c1047,1048
<   next if ! defined $var;
---
> #  next if ! defined $var;
>  if ( defined $var ) {
1063a1065
>  }

Would it be possible to incorporate this in the forthcomming
release?

Thanks a million,

Ton

-
To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list


Search for: Match: Format: Sort by: