[mv] MV 4.04 CyberCash error reporting bug & proposed fix

[Randy Moore <ramoore@axion-it.net>]

******    message to minivend-users from Randy Moore <ramoore@axion-it.net>     ******

Hello,

While trying to get CyberCash working in MV 4.04, I noticed that in some 
cases, error messages from CyberCash were not being returned.  This 
resulted in rather opaque messages from the [error] tag such as:
	Charge operation '' failed

I got this message when using the test credit card number against a real 
live cybercash account.  After some digging, I found that CyberCash was 
properly returning an error like:
	CR message:  Financial Institution Response: Declined, bad 
card.  Call 		card issuer.

The proposed fix I give below will return a more useful error message in 
the [error] tag.

In Order.pm at around line 152, change:
$message = "Charge operation '$ref->{mv_cyber_mode}' failed" if ! $message;

to:
$message = "Charge operation '$params' failed.";
if ($Vend::Session->{cybercash_error}) {
$message .= " CyberCash Response:  $Vend::Session->{cybercash_error}";
}

There is a second issue which this doesn't address for those with sites 
based on the 'simple' demo included with MV 4.x.  Instead of showing the 
text of returned messages, the demo uses the [error name="..."] tag to 
highlight areas where their are order problem in red.  For some kinds of 
CyberCash errors, the Credit Card Information header never gets set to red, 
so the customer doesn't have any way to know what is causing his order to 
keep looping back to the checkout page.

I don't understand how this works well enough to propose a solution, but 
hopefully someone else can jump in here.

Hope this helps.



Randy Moore
Axion Information Technologies, Inc.

email     ramoore@axion-it.net
phone   301-408-1200
fax        301-445-3947
-
To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list