[Camps-users] [Camps-commits] [SCM] Camps development environments branch, master, updated. 71dc7b5e3651237c99f116565bac75474d378a5e

[Davor Ocelic]

On Tue, 20 Jan 2009 11:48:29 -0500
"Brian J. Miller" <brian at endpoint.com> wrote:

> Jon Jensen wrote:
> > +
> >      die "Configuration file '$file' contains unterminated <<HERE
> > doc (<$mark_type$marker)!\n" if defined $marker; die "Configuration
> > file '$file' contained unterminated #ifdef!\n" if defined $ifdef;
> > -    close $CONF;
> > +    close $CONF or die "Error closing $file\n";
> >  
> 
> I've never been real clear on why this would happen, should this be an
> exception over a warning? (There are a couple of additional ones like
> this that I'm going to snip out below.) Either way this exception
> should include $! so that we know why, arguably which file couldn't
> be closed is less valuable.

Yeah, adding $! would be useful, and also if you use a filesystem that
does write on close (such as AFS), this is an important notice.

-doc