[Camps-users] [Camps-commits] [devcamps/camps] c9436c: Add new copy_path feature 'linkdepth'. This allow...

[Jon Jensen]

Sam,

I just reviewed this commit, which is now at:

https://github.com/devcamps/camps/commit/c9436c8ba7ca46fe4fe6f22b26e360b9d35eabfc

and would like to get it into the mainline camps system.

I'd like to discuss a couple of minor changes first, though.

A simple one: I suggest "link_depth" instead of "linkdepth", to stick with 
the config variable convention like "default_link" rather than 
"defaultlink".

Next, I think "link depth" implies a number saying at what directory depth 
the symlinks should happen. In other words, "1" seems like a number, not a 
boolean, saying to symlink at depth 1. And I would expect "2" would 
symlink at directly depth 2.

Does that make sense conceptually?

If so, do you think it would be a problem to implement that way?

Thanks,
Jon


On Tue, 18 Apr 2017, GitHub wrote:

>  Branch: refs/heads/linkdepth
>  Home:   https://github.com/devcamps/camps
>  Commit: c9436c8ba7ca46fe4fe6f22b26e360b9d35eabfc
>      https://github.com/devcamps/camps/commit/c9436c8ba7ca46fe4fe6f22b26e360b9d35eabfc
>  Author: Sam Batschelet <samb at endpoint.com>
>  Date:   2017-04-18 (Tue, 18 Apr 2017)
>
>  Changed paths:
>    M lib/Camp/Master.pm
>
>  Log Message:
>  -----------
>  Add new copy_path feature 'linkdepth'.  This allows symlinking
> all of the 1st level files and directories of the source to the
> target.
>
>
>  Commit: bb48c2d23f60912d80ad710d99c462445621088a
>      https://github.com/devcamps/camps/commit/bb48c2d23f60912d80ad710d99c462445621088a
>  Author: Sam Batschelet <samb at endpoint.com>
>  Date:   2017-04-18 (Tue, 18 Apr 2017)
>
>  Changed paths:
>    M lib/Camp/Master.pm
>
>  Log Message:
>  -----------
>  Merge branch 'mysql_57' into linkdepth
>
>
> Compare: https://github.com/devcamps/camps/compare/c9436c8ba7ca^...bb48c2d23f60