[interchange-cvs] interchange - heins modified lib/Vend/Util.pm

interchange-core@interchange.redhat.com interchange-core@interchange.redhat.com
Sat Feb 16 13:28:01 2002


User:      heins
Date:      2002-02-16 18:27:19 GMT
Modified:  lib/Vend Util.pm
Log:
	* For some reason, HTML::Entities was seeing a void context in my
	  preload for its escape routines, and the "modification of a read-only
	  value" was happening there.

	  "make test" should now work for the build.

Revision  Changes    Path
2.21      +7 -8      interchange/lib/Vend/Util.pm


rev 2.21, prev_rev 2.20
Index: Util.pm
===================================================================
RCS file: /anon_cvs/repository/interchange/lib/Vend/Util.pm,v
retrieving revision 2.20
retrieving revision 2.21
diff -u -r2.20 -r2.21
--- Util.pm	8 Feb 2002 23:08:21 -0000	2.20
+++ Util.pm	16 Feb 2002 18:27:19 -0000	2.21
@@ -1,6 +1,6 @@
 # Vend::Util - Interchange utility functions
 #
-# $Id: Util.pm,v 2.20 2002/02/08 23:08:21 mheins Exp $
+# $Id: Util.pm,v 2.21 2002/02/16 18:27:19 mheins Exp $
 # 
 # Copyright (C) 1996-2001 Red Hat, Inc. <interchange@redhat.com>
 #
@@ -82,7 +82,7 @@
 use Safe;
 use subs qw(logError logGlobal);
 use vars qw($VERSION @EXPORT @EXPORT_OK);
-$VERSION = substr(q$Revision: 2.20 $, 10);
+$VERSION = substr(q$Revision: 2.21 $, 10);
 
 BEGIN {
 	eval {
@@ -117,16 +117,15 @@
 ## This is a character class for HTML::Entities
 $ESCAPE_CHARS::std = "^\n\t !\#\$%\'-;=?-Z\\\]-~";
 
-## HTML::Entities caches this, let's get it cached right away so
-## each child doesn't have to re-eval
-{
-	my $junk = HTML::Entities::encode(">>>123<<<", $ESCAPE_CHARS::std);
-}
-
 my $need_escape;
 
 sub setup_escape_chars {
     my($ok, $i, $a, $t);
+
+	## HTML::Entities caches this, let's get it cached right away so
+	## each child doesn't have to re-eval
+	my $junk = ">>>123<<<";
+	HTML::Entities::encode($junk, $ESCAPE_CHARS::std);
 
     foreach $i (0..255) {
         $a = chr($i);