[interchange-cvs] interchange - heins modified lib/Vend/Order.pm

[interchange-cvs at icdevgroup.org]

User:      heins
Date:      2003-07-27 19:47:58 GMT
Modified:  lib/Vend Order.pm
Log:
* Remove insurance of trailing null fields being included in arrays.
  Any traversing of the arrays should be keyed on code/sku anyway,
  and that is the only one that needs to be fully populated.

  Fix provided by Brian Rogers of Groxis -- caused problems for one
  of his custom ordering routines.

Revision  Changes    Path
2.58      +10 -10    interchange/lib/Vend/Order.pm


rev 2.58, prev_rev 2.57
Index: Order.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Order.pm,v
retrieving revision 2.57
retrieving revision 2.58
diff -u -r2.57 -r2.58
--- Order.pm	18 Jun 2003 17:34:44 -0000	2.57
+++ Order.pm	27 Jul 2003 19:47:58 -0000	2.58
@@ -1,6 +1,6 @@
 # Vend::Order - Interchange order routing routines
 #
-# $Id: Order.pm,v 2.57 2003/06/18 17:34:44 jon Exp $
+# $Id: Order.pm,v 2.58 2003/07/27 19:47:58 mheins Exp $
 #
 # Copyright (C) 2002-2003 Interchange Development Group
 # Copyright (C) 1996-2002 Red Hat, Inc.
@@ -29,7 +29,7 @@
 package Vend::Order;
 require Exporter;
 
-$VERSION = substr(q$Revision: 2.57 $, 10);
+$VERSION = substr(q$Revision: 2.58 $, 10);
 
 @ISA = qw(Exporter);
 
@@ -2268,11 +2268,11 @@
 		$cart = $Vend::Items;
 	}
 
-	@items      = split /\0/, ($items), -1;
-	@quantities = split /\0/, ($quantities || delete $CGI::values{mv_order_quantity} || ''), -1;
-	@bases      = split /\0/, delete $CGI::values{mv_order_mv_ib}, -1
+	@items      = split /\0/, ($items);
+	@quantities = split /\0/, ($quantities || delete $CGI::values{mv_order_quantity} || '');
+	@bases      = split /\0/, delete $CGI::values{mv_order_mv_ib}
 		if defined $CGI::values{mv_order_mv_ib};
-	@lines      = split /\0/, delete $CGI::values{mv_orderline}, -1
+	@lines      = split /\0/, delete $CGI::values{mv_orderline}
 		if defined $CGI::values{mv_orderline};
 
 	if($CGI::values{mv_order_fly} and $Vend::Cfg->{OnFly}) {
@@ -2280,7 +2280,7 @@
 			@fly = $CGI::values{mv_order_fly};
 		}
 		else {
-			@fly = split /\0/, $CGI::values{mv_order_fly}, -1;
+			@fly = split /\0/, $CGI::values{mv_order_fly};
 		}
 	}
 
@@ -2293,7 +2293,7 @@
 	}
 
 	if($CGI::values{mv_sku}) {
-		my @sku = split /\0/, $CGI::values{mv_sku}, -1;
+		my @sku = split /\0/, $CGI::values{mv_sku};
 		for (@sku) {
 			$_ = $::Variable->{MV_VARIANT_JOINER} || '0' if ! length($_);
 		}
@@ -2305,7 +2305,7 @@
 		foreach $attr (@{$Vend::Cfg->{UseModifier} || []}) {
 			$attr{$attr} = [];
 			next unless defined $CGI::values{"mv_order_$attr"};
-			@{$attr{$attr}} = split /\0/, $CGI::values{"mv_order_$attr"}, -1;
+			@{$attr{$attr}} = split /\0/, $CGI::values{"mv_order_$attr"};
 		}
 	}
 
@@ -2331,7 +2331,7 @@
 						);
 	}
 
-	@group   = split /\0/, (delete $CGI::values{mv_order_group} || ''), -1;
+	@group   = split /\0/, (delete $CGI::values{mv_order_group} || '');
 	for( my $i = 0; $i < @group; $i++ ) {
 	   $attr{mv_mi}->[$i] = $group[$i] ? ++$Vend::Session->{pageCount} : 0;
 	}