[interchange-cvs] interchange - kwalsh modified lib/Vend/Ship.pm

[interchange-cvs at icdevgroup.org]

User:      kwalsh
Date:      2006-08-24 20:57:25 GMT
Modified:  lib/Vend Ship.pm
Log:
    * Autovivification issue: The temporary mv_shipping cart was left
      undefined instead of being removed in some cases.  In fact, in the
      test case that showed the error, the mv_shipping cart was just being
      defined as undef and left as-is.  The undef "cart" caused problems
      in later cart recalculations.

Revision  Changes    Path
2.19      +2 -2      interchange/lib/Vend/Ship.pm


rev 2.19, prev_rev 2.18
Index: Ship.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Ship.pm,v
retrieving revision 2.18
retrieving revision 2.19
diff -u -r2.18 -r2.19
--- Ship.pm	5 Apr 2006 14:42:19 -0000	2.18
+++ Ship.pm	24 Aug 2006 20:57:25 -0000	2.19
@@ -1,6 +1,6 @@
 # Vend::Ship - Interchange shipping code
 # 
-# $Id: Ship.pm,v 2.18 2006/04/05 14:42:19 mheins Exp $
+# $Id: Ship.pm,v 2.19 2006/08/24 20:57:25 kwalsh Exp $
 #
 # Copyright (C) 2002-2005 Interchange Development Group
 # Copyright (C) 1996-2002 Red Hat, Inc.
@@ -854,7 +854,7 @@
 	SHIPFORMAT: {
 		$Vend::Session->{ship_message} .= $error_message . ($error_message =~ / $/ ? '' : ' ')
 			if defined $error_message;
-		undef $::Carts->{mv_shipping};
+		delete $::Carts->{mv_shipping};
 		$Vend::Items = $save;
 #::logDebug("Check FINAL. Vend::Items=$Vend::Items main=$::Carts->{main}");
 		last SHIPFORMAT unless defined $final;