[interchange-cvs] interchange - racke modified lib/Vend/Table/DBI.pm

[interchange-cvs at icdevgroup.org]

User:      racke
Date:      2007-06-11 08:11:44 GMT
Modified:  lib/Vend/Table DBI.pm
Log:
throw an error if autoconfiguration fails, including error message from DBI
drawback of this patch:
Could not open error file : No such file or directory

Revision  Changes    Path
2.76      +10 -5     interchange/lib/Vend/Table/DBI.pm


rev 2.76, prev_rev 2.75
Index: DBI.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Table/DBI.pm,v
retrieving revision 2.75
retrieving revision 2.76
diff -u -r2.75 -r2.76
--- DBI.pm	11 Apr 2007 11:16:25 -0000	2.75
+++ DBI.pm	11 Jun 2007 08:11:43 -0000	2.76
@@ -1,8 +1,8 @@
 # Vend::Table::DBI - Access a table stored in an DBI/DBD database
 #
-# $Id: DBI.pm,v 2.75 2007/04/11 11:16:25 pajamian Exp $
+# $Id: DBI.pm,v 2.76 2007/06/11 08:11:43 racke Exp $
 #
-# Copyright (C) 2002-2006 Interchange Development Group
+# Copyright (C) 2002-2007 Interchange Development Group
 # Copyright (C) 1996-2002 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
@@ -21,7 +21,7 @@
 # MA  02110-1301  USA.
 
 package Vend::Table::DBI;
-$VERSION = substr(q$Revision: 2.75 $, 10);
+$VERSION = substr(q$Revision: 2.76 $, 10);
 
 use strict;
 no warnings qw(uninitialized numeric);
@@ -2139,8 +2139,13 @@
 sub auto_config {
 	my $string = shift;
 	my ($dsn, $user, $pass, $catalog, $schema, $name, $type) = Text::ParseWords::shellwords($string);
-	my $handle = DBI->connect($dsn, $user, $pass)
-		or ::logDebug(::errmsg("DatabaseAuto DSN '%s' does not connect.", $dsn));
+	my $handle = DBI->connect($dsn, $user, $pass);
+
+	unless ($handle) {
+		::logError(::errmsg("DatabaseAuto DSN '%s' does not connect: %s", $dsn, $DBI::errstr));
+		return;
+	}
+	
 	my @tabs;
 	my @out;
 	my $sth;