[interchange-cvs] interchange - racke modified 2 files

[interchange-cvs at icdevgroup.org]

User:      racke
Date:      2008-03-25 15:23:10 GMT
Modified:  .        WHATSNEW-5.5
Modified:  code/UserTag button.tag
Log:
Fixed invalid JavaScript generated by the button tag (#135)

Revision  Changes    Path
1.99                 interchange/WHATSNEW-5.5


rev 1.99, prev_rev 1.98
Index: WHATSNEW-5.5
===================================================================
RCS file: /var/cvs/interchange/WHATSNEW-5.5,v
retrieving revision 1.98
retrieving revision 1.99
diff -u -r1.98 -r1.99
--- WHATSNEW-5.5	24 Mar 2008 15:30:10 -0000	1.98
+++ WHATSNEW-5.5	25 Mar 2008 15:23:10 -0000	1.99
@@ -115,6 +115,8 @@
 * Added scratch option to [get-url] for saving binary content into a scratch
   variable instead of returning it.
 
+* Fixed invalid JavaScript generated by the button tag (#135).
+
 Payment
 -------
 



1.24                 interchange/code/UserTag/button.tag


rev 1.24, prev_rev 1.23
Index: button.tag
===================================================================
RCS file: /var/cvs/interchange/code/UserTag/button.tag,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- button.tag	4 Aug 2007 00:32:41 -0000	1.23
+++ button.tag	25 Mar 2008 15:23:10 -0000	1.24
@@ -1,17 +1,17 @@
-# Copyright 2002-2007 Interchange Development Group and others
+# Copyright 2002-2008 Interchange Development Group and others
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 2 of the License, or
 # (at your option) any later version.  See the LICENSE file for details.
 # 
-# $Id: button.tag,v 1.23 2007-08-04 00:32:41 kwalsh Exp $
+# $Id: button.tag,v 1.24 2008-03-25 15:23:10 racke Exp $
 
 UserTag button Order     name src text
 UserTag button addAttr
 UserTag button attrAlias value text
 UserTag button hasEndTag
-UserTag button Version   $Revision: 1.23 $
+UserTag button Version   $Revision: 1.24 $
 UserTag button Routine   <<EOR
 sub {
 	my ($name, $src, $text, $opt, $action) = @_;
@@ -108,9 +108,6 @@
 	# for JavaScript-challenged browsers.
 	$text =~ s/"/&quot;/g;
 	$name =~ s/"/&quot;/g;
-	if(! $onclick and $confirm) {
-		$onclick = qq{ onclick="return $confirm"};
-	}
 	$out = qq{<input type="submit" name="$name" value="$text"$onclick$Vend::Xtrailer>};
 	if (@js) {
 		$out =~ s/ /join "\n", '', @js, ''/e;