[interchange] Revert "Only apply GDBM filters if they are not already installed"

David Christensen interchange-cvs at icdevgroup.org
Fri Aug 31 16:01:42 UTC 2012


commit 6015f6fd09b1167d69d62e0649f0ce7f9674cb84
Author: David Christensen <david at endpoint.com>
Date:   Fri Aug 31 10:52:07 2012 -0500

    Revert "Only apply GDBM filters if they are not already installed"
    
    As per Racke's feedback this code is broken.  There's such a fine line between optimism and denial...
    
    This reverts commit 0c31ea3287df97c8fedbf23ad71244e4ebe019c7.

 lib/Vend/Table/GDBM.pm |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/lib/Vend/Table/GDBM.pm b/lib/Vend/Table/GDBM.pm
index 559f904..fb82dbb 100644
--- a/lib/Vend/Table/GDBM.pm
+++ b/lib/Vend/Table/GDBM.pm
@@ -150,10 +150,10 @@ sub apply_utf8_filters {
 	my $out_filter = sub { $_ = encode('utf-8', $_) };
 	my $in_filter  = sub { $_ = decode('utf-8', $_) };
 
-	$handle->filter_store_key($out_filter)   unless $handle->filter_store_key();
-	$handle->filter_store_value($out_filter) unless $handle->filter_store_value();
-	$handle->filter_fetch_key($in_filter)    unless $handle->filter_fetch_key();
-	$handle->filter_fetch_value($in_filter)  unless $handle->filter_fetch_value();
+	$handle->filter_store_key($out_filter);
+	$handle->filter_store_value($out_filter);
+	$handle->filter_fetch_key($in_filter);
+	$handle->filter_fetch_value($in_filter);
 
 	return $handle;
 }



More information about the interchange-cvs mailing list