[ic] One more time: Promotions inconsistent behavior

[Dan Browning]

--=====================_90075491==_
Content-Type: text/plain; charset="us-ascii"; format=flowed

At 02:52 PM 8/2/2002 -0700, you wrote:
>--- Dan Browning <dbml@kavod.com> wrote:
> > By "didn't work", you mean that it continued to
> > display "Specials" and "New
> > Items" only, or do you mean that it didn't display
> > anything?
>
>It continued to display only "Specials" and "New
>Items"
>
> > Perhaps the
> > metadata is in an unexpected format.  To confirm,
> > please do the following:
>
>Did it, same result.  FYI the field already contained
>the following:
>
>=none,
>demos=Demos,
>specials=Specials,
>new=New item,
>expired=expired
>
>-B

After working with Brian off-list for a little while, I found a better 
solution by patching the page_edit functionality to accept additional 
display commands, which:

  * Fixes the select list
  * Beautifies the display (uses the option names instead of params)
  * Add... [promotion] option displayed

Apply page_edit.patch to VENDROOT/lib/UI/pages/include/page_edit
Apply promo.patch to CATROOT/templates/components/promo

+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Dan Browning, Kavod Technologies <db@kavod.com>
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Maturity is only a short break in adolescence.
                 -- Jules Feiffer


--- promo.orig      Sat Aug  4 07:56:24 2001
+++ promo       Wed Jul 31 03:40:58 2002
@@ -6,8 +6,9 @@

  promo_type:
         label: Promotion type
-       options: specials=Specials, new=New items
         widget: select
+       column: featured
+       table: merchandising

  matches:
         label: Number to show



--- page_edit.orig      Wed Jul 31 05:21:29 2002
+++ page_edit   Wed Jul 31 05:35:03 2002
@@ -794,6 +794,8 @@
                                                                         filter 
=> $r->{filter},
                                                                         pre_filter 
=> $r->{prefilter},
                                                                         template 
=> $control_template,
+ 
table => $r->{table},
+ 
column => $r->{column},
                                                                 });
                                         push @messages, "widget='$widget'";
                                         # No meta for now

--=====================_90075491==_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: attachment; filename="promo.patch"

--- promo.orig      Sat Aug  4 07:56:24 2001
+++ promo       Wed Jul 31 03:40:58 2002
@@ -6,8 +6,9 @@

 promo_type:
        label: Promotion type
-       options: specials=Specials, new=New items
        widget: select
+       column: featured
+       table: merchandising

 matches:
        label: Number to show
--=====================_90075491==_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: attachment; filename="page_edit.patch"

--- page_edit.orig      Wed Jul 31 05:21:29 2002
+++ page_edit   Wed Jul 31 05:35:03 2002
@@ -794,6 +794,8 @@
                                                                        filter => $r->{filter},
                                                                        pre_filter => $r->{prefilter},
                                                                        template => $control_template,
+                                                                       table => $r->{table},
+                                                                       column => $r->{column},
                                                                });
                                        push @messages, "widget='$widget'";
                                        # No meta for now

--=====================_90075491==_--