[ic] [timed-build] not working for logged in users
Jon Jensen
jon at endpoint.com
Fri Jul 14 18:21:54 EDT 2006
On Fri, 14 Jul 2006, Kevin Walsh wrote:
>>> UserDB clears $Vend::Cookie at login time. I don't know why.
>>
>> Then either that behavior should be fixed, or [timed-login] needs to be
>> changed so that it checks something more reliable than $Vend::Cookie.
>>
>> The next step would probably be to determine if there is any other code
>> which relies on this strange behavior of $Vend::Cookie.
>>
> The following patch works for me. You can try it, but you should be
> aware that it could possibly cause unintended side-effects. I have been
> running with the patch in since 21 March 2006 and haven't found any yet.
>
> ----------------------------------------------------------------------
> --- Dispatch.pm 27 Jun 2006 14:24:42 -0000 1.69
> +++ Dispatch.pm 14 Jul 2006 01:45:48 -0000
> @@ -1394,8 +1394,6 @@
>
> $Vend::Session->{'user'} = $CGI::user;
>
> - undef $Vend::Cookie if $Vend::Session->{logged_in};
> -
> $CGI::pragma = 'no-cache'
> if delete $::Scratch->{mv_no_cache};
> #show_times("end session get") if $Global::ShowTimes;
Kevin,
Shouldn't we get rid of the "undef $Vend::Cookie" that occurs twice in
Vend::UserDB as well? It's done at login time and when a new account is
created, and would cause the same problems as the above code you removed
from Vend::Dispatch, but only for the page in which a login/new account
creation occurs.
Jon
--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
More information about the interchange-users
mailing list