[ic] IC 5.6.0 parse_page: Error parsing page. - Possible Bug

[Gert van der Spoel]

> -----Original Message-----
> From: interchange-users-bounces at icdevgroup.org [mailto:interchange-
> users-bounces at icdevgroup.org] On Behalf Of Mike Heins
> Sent: zondag 6 juli 2008 19:21
> To: interchange-users at icdevgroup.org
> Subject: Re: [ic] IC 5.6.0 parse_page: Error parsing page. - Possible
> Bug
> 
> Quoting ic at 3edge.com (ic at 3edge.com):
> > > -----Original Message-----
> > > From: interchange-users-bounces at icdevgroup.org [mailto:interchange-
> > > users-bounces at icdevgroup.org] On Behalf Of Andrew Rich
> > > Sent: zondag 22 juni 2008 14:46
> > > To: interchange-users at icdevgroup.org
> > > Subject: Re: [ic] IC 5.6.0 parse_page: Error parsing page. -
> Possible
> > > Bug
> > >
> > > > I was able to get this same error on the demo1 site.
> > > >
> > > > create new page with left and top areas.
> > > >
> > > > I am not sure if creating a new page is a site restriction
> > > > (permissions error) or an actual bug.
> > > >
> > > > Anyone want to give this a try that has access to the Demo
> server?
> > > >
> > > > Steve
> > >
> > > Is there anyone able to help with this error as my customer is
> unable
> > > to
> > > edit their website properly?
> >
> > I've been going over this issue during this weekend, install IC 5.6.0
> with
> > the Standard demo, trying to figure out what is happening. Also to
> refer to
> > a previous thread by Ton & Stefan:
> > http://www.icdevgroup.org/pipermail/interchange-users/2007-
> February/047035.h
> > tml
> >
> > A quick work around to be able to create new pages is to comment out
> lines
> > 2886-2889 in lib/UI/ContentEditor.pm  and add a ; to the line before
> > (parse_page($pref, $opt)). What this breaks, no clue - Mike jump in
> any time
> > ;)
> 
> Dear Gert,
> 
> Do you have this in patch form? I am having trouble visualizing
> what you are saying.
> 
> It seems that the parse_page() routine is returning false, as you
> found. When I remove the test for it's return value, everything
> works fine. (At least as fine as that ever worked.)


Hi Mike,

Below the patch. And yes this patch works (as in "it works fine" if you
remove the code), however you added this code at some point to solve another
issue:

revision 2.18
date: 2006-05-04 20:07:32 +0000;  author: mheins;  state: Exp;  lines: +14
-3;
* Add special not_editable control to prevent editing pages that will
  be killed by the content editor.

I have gone over the various mailinglists if there was any explanation for
this addition, but I could not find it. But removing this code voids your
May 2006 patches. If you could dig back into your mind to find out why this
was done, then perhaps we can find another way to implement the test for non
editable controls.

CU,

Gert

The patch:

--- ContentEditor.pm    2008-07-07 06:51:13.000000000 +0200
+++ /opt/site/cvs/interchange/dist/lib/UI/ContentEditor.pm      2008-04-24
11:07:57.000000000 +0200
@@ -2881,7 +2881,12 @@

        save_store('page', $name, $pref);

-       parse_page($pref, $opt);
+       ## If returns false then must be error or not editable
+       parse_page($pref, $opt)
+               or do {
+                       Vend::Tags->error({ name => 'parse_page', set =>
"Error parsing page." });
+                       return;
+               };

        publish_page($pref, $opt) if $opt->{new};