[ic] IC 5.6.0 parse_page: Error parsing page. - Possible Bug

ic at 3edge.com ic at 3edge.com
Tue Jul 8 09:30:58 UTC 2008


Andrew Rich writes: 

>> Quoting Gert van der Spoel (gert at 3edge.com):
>> > --- ContentEditor.pm    2008-07-07 06:51:13.000000000 +0200
>> > +++ /opt/site/cvs/interchange/dist/lib/UI/ContentEditor.pm      2008-
>> 04-24
>> > 11:07:57.000000000 +0200
>> > @@ -2881,7 +2881,12 @@
>> >
>> >         save_store('page', $name, $pref);
>> >
>> > -       parse_page($pref, $opt);
>> > +       ## If returns false then must be error or not editable
>> > +       parse_page($pref, $opt)
>> > +               or do {
>> > +                       Vend::Tags->error({ name => 'parse_page', set
>> =>
>> > "Error parsing page." });
>> > +                       return;
>> > +               };
>> >
>> >         publish_page($pref, $opt) if $opt->{new};
>> >
>> > 
>> 
>> I think this is reasonable to do. 
>> 
>> They say a man should be able to shoot his own dog, and that means
>> you had better make the patch in 5.6 stable. Because this dog is going
>> to be shot in the current CVS tree. 
>> 
> 
> Not sure if there was a mix up in there but this is what Gert said to do in
> his first e-mail which is the opposite to the above patch.
> So, yes, what are the consequences of doing this?  One thing for sure is
> that I can now edit pages under 5.6.0 again on sites based upon the standard
> demo with these changes. 
> 
> --- ContentEditor.x     Sun May 25 19:51:15 2008
> +++ ContentEditor.pm    Tue Jul  8 15:29:08 2008
> @@ -2882,11 +2882,11 @@
>         save_store('page', $name, $pref); 
> 
>         ## If returns false then must be error or not editable
> -       parse_page($pref, $opt)
> -               or do {
> -                       Vend::Tags->error({ name => 'parse_page', set =>
> "Error parsing page." });
> -                       return;
> -               };
> +       parse_page($pref, $opt);
> +#              or do {
> +#                      Vend::Tags->error({ name => 'parse_page', set =>
> "Error parsing page." });
> +#                      return;
> +#              }; 
> 
>         publish_page($pref, $opt) if $opt->{new}; 
> 
> Thanks for the effort Gert.

Ah I probably put the diff the opposite direction....
The consequences are not very clear, but quite likely less severe than not 
being able to create any pages at all :) 

CU, 

Gert



More information about the interchange-users mailing list