[ic] Verifone IPCharge

Richard Siddall richard.siddall at elirion.net
Fri Mar 20 20:23:48 UTC 2009


Mike Heins wrote:
> Remember too, that the very nature of Business::OnlinePayment means
> that you have the potential to be adding new parameters all the time, as you
> add payment modules. You have to pass them along somehow.
> 

I'm aware of that.  I believe Ivan Kohler was aware of it too when he 
provided a way of passing additional parameters to the 
Business::OnlinePayment constructor.

> Passing *all* of $opt along means a chance of conflict. So the mappable
> extra parameters seems ideal to me. The alternative is hacking on
> the module code all the time, which seems non-optimal to me.
> 

I don't see why you'd have to hack on the module code if you already 
have a way of passing extra parameters.  Adding a second way of doing it 
just bloats the code.

Note that the existing code specifically greps some keys out of the $opt 
  hash.

Regards,

	Richard



More information about the interchange-users mailing list