[ic] Patch to differentiate between free shipping and unavailable shipping methods
Stefan Hornburg
racke at linuxia.de
Wed May 27 13:20:01 UTC 2009
Mike Heins wrote:
> Quoting Mark Lipscombe (markl at gasupnow.com):
>> Stefan Hornburg wrote:
>>> Objection one: this is same as $cost >= 0
>>> Objection two: this takes away cumulative calculation and also $m is
>>> superfluous.
>> Based on racke's feedback, here is an updated patch which addresses his
>> concerns.
>>
>> The shipping code is a pretty intimidating piece of Perl to try and wrap
>> one's head around without any documentation.
>
> It's intimidating perhaps because of lack of comments. But it did (and I believe
> still does) have 25 pages of documentation. 8-)
>
In my opinion that's a clear indicator that this code shouldn't be included
by default.
Regards
Racke
--
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team
More information about the interchange-users
mailing list