[ic] Patch to differentiate between free shipping and unavailable shipping methods
Jon Jensen
jon at endpoint.com
Thu May 28 18:45:32 UTC 2009
On Thu, 28 May 2009, Mark Lipscombe wrote:
>> Here's another squashed commit of your changes for the undef shipping
>> change:
>>
>> http://github.com/jonjensen/interchange/commits/ship-return-undef
>>
>> It is easiest to work with these patches on GitHub if you use a
>> separate branch for each change, and then later if we squash the
>> commits so we don't get every intermediate tweak on the way to a final
>> patch.
>>
>> Please let me know if that looks ok.
>
> That one also looks fine. I'm still a Git newbie, I will do that from
> now on.
Ok, I pushed out the Authorize.net change.
But the undef shipping I have a question about. Your "last SHIPIT" that
checks for definedness doesn't also check the $o->{continue} as the other
code does. Will that omission introduce a bug by not continuing when it
should?
Jon
--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
More information about the interchange-users
mailing list