[ic] [interchange] Fix encode_special_entities filter to prevent heredoc parsing error

Stefan Hornburg (Racke) racke at linuxia.de
Fri Nov 12 19:56:33 UTC 2010


On 11/12/2010 07:36 PM, Jon Jensen wrote:
> On Fri, 12 Nov 2010, Stefan Hornburg (Racke) wrote:
>
>> That's good for now, but I suggest to fix the heredoc bug inside
>> Interchange :-).
>
> It's not actually a bug, if you consider Perl's heredocs to be the
> standard for how heredocs work. Perl heredocs require a newline at the
> end of the token, or you get this error:
>
> Can't find string terminator "END" anywhere before EOF
>

OK, but Interchange doesn't complain. Silent failure smells like a bug too.

> Text files are arrays of lines, and each line ends with \n. Thus normal
> text files should always end with a newline, or they're broken.
>

Which standard defines that :-) ?

> vi, Vim, and nano do that by default, but emacs doesn't. It can be set
> to do so with this in ~/.emacs:
>
> (setq require-final-newline t)
>

OK, that might be good idea.

Regards
	Racke



-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team




More information about the interchange-users mailing list