[ic] [interchange] Rely on DBI to provide quoting when necessary, prevent problems

Mike Heins mike at perusion.com
Fri Feb 4 05:58:49 UTC 2011


Quoting Mike Heins (mike at perusion.com):
> Quoting David Christensen (david at endpoint.com):
> > 
> > On Feb 3, 2011, at 9:31 PM, Mike Heins wrote:
> > 
> > > Quoting David Christensen (david at endpoint.com):
> > >>> +	$key = $s->[$WDBI]->quote($key, $s->[$KEY]);
> > >> 
> > >> 
> > >> Mike,
> > >> 
> > >> Did you mean $DBI instead of $WDBI?
> > > 
> > > No, I was duplicating the same handle used by the previous code.
> > > 
> > > In fact, I would think the second one should be $WDBI, and I will
> > > correct that, as I believe it is a bug for it to be $DBI. You caught
> > > that with your question, thank you. 8-)
> > 
> > 
> > I'm confused, then; this looks like the only instance of $WDBI in the
> > entire codebase. Where is this defined, otherwise?
> 
> You are correct. I was working off of a branch. I knew git was going
> to get me... 8-). I will get better at it as I finally start to use
> it.
> 
> $WDBI is a change I have in a branch. It allows a separate write handle
> so that you can operate a the catalog off of a slave while making any
> updates to a separate write handle.
> 

Fixed! Thanks for catching this.

-- 
Mike Heins
Perusion -- Expert Interchange Consulting    http://www.perusion.com/
phone +1.765.328.4479  <mike at perusion.com>

An amateur practices until he gets it right. A pro
practices until he can't get it wrong. -- unknown



More information about the interchange-users mailing list