[ic] Bugfix for image.tag

Josh Lavin josh at perusion.net
Tue Mar 15 21:46:31 UTC 2011


On 03/15/2011 04:21 PM, Jon Jensen wrote:
> On Tue, 15 Mar 2011, Josh Lavin wrote:
>
>> Here is the "real" bugfix. Thanks to Jon for pointing me in the right
>> direction and helping to expose a flaw in the way I originally fixed
>> the bug. This time, I fixed $siz instead of mistakenly modifying the
>> filename.
>
> Now it seems like you're removing any of those special characters from
> size altogether, not just for the directory name:
>
> $siz =~ s:[^\dx]::g;
> $dir .= "/$siz";
>
>> From then on, $siz would only have "200", not "200>" if you'd given the
> latter.
>
> Shouldn't it be something like:
>
> (my $size_path = $siz) =~ s:[^\dx]::g;
> $dir .= "/$siz";
>
> instead?

Whoops... you are right. Trying again:

https://github.com/jlavin/interchange/commit/03b3d8901c0fb97512ab734aaadfda172a16ad1a

-- 
Josh Lavin
Perusion -- Expert Interchange Consulting    http://www.perusion.com/



More information about the interchange-users mailing list