[ic] Replace Digest::SHA1 with Digest::SHA

[Gert van der Spoel]

> -----Original Message-----
> From: interchange-users-bounces at icdevgroup.org [mailto:interchange-users-
> bounces at icdevgroup.org] On Behalf Of Stefan Hornburg (Racke)
> Sent: maandag 9 mei 2011 9:54
> To: interchange-users at icdevgroup.org
> Subject: [ic] Replace Digest::SHA1 with Digest::SHA
> 
> Hello, Interchange enthusiasts!
> 
> The attached patch replaces Digest::SHA1 in Digest::SHA as requested in
> the
> Debian bug #625904 (http://bugs.debian.org/cgi-
> bin/bugreport.cgi?bug=625904).
> 
> I would be great if someone can test this patch as this should be part
> of the upcoming 5.7.7.
> 

Not tested the patch, but couple small remarks regarding the patch:

1- Current UPGRADE document shows: 
  5.6.x -- Perl 5.8.5 or newer is now required to run Interchange.

  The bug report shows:
  Digest::SHA is in Perl core since version 5.9.3 and thus is in
Debian's perl since Lenny.

  So does this mean we should update the UPGRADE document that with 5.7.x
Perl 5.9.3 or newer is required? (Or is it actually already Perl 5.10.x
because of the UTF8 story?)

2- 
-    ::logGlobal("SHA1 passwords disabled: $@");
+    ::logGlobal("SHA passwords disabled: $@");

and 

-    unless ($HAVE_SHA1) {
-        $obj->log_either('SHA1 passwords unavailable. Is Digest::SHA1
installed?');
+    unless ($HAVE_SHA) {
+        $obj->log_either('SHA passwords unavailable. Is Digest::SHA
installed?');


I think that it is not needed to change these logging messages, Because it
is a SHA1 password that is created, not a SHA password ....

CU,

Gert