Re: [mv] 4.04 Bugfix Order.pm

[Mike Heins <mikeh@minivend.com>]

******    message to minivend-users from Mike Heins <mikeh@minivend.com>     ******

Quoting Ton Verhagen (ton@verhagen.net):
> ******    message to minivend-users from "Ton Verhagen" <ton@verhagen.net>     ******
> 
> Hi all,
> 
> Order.pm: &return=1 and &return=0
> 
> If &return=1 is set in an order_profile, everything works as
> expected. However when &return is set to 0, the expression
> $status=$Success will never be evaluated true causing ($status =
> $Success and last) always to fail! The code will not behave as
> expected, namely abort processing of the order_profile and return
> failpage/nextpage.
> 
> Here's a patch that solves the problem:
> 1065c1065
> <   ($status = $Success and last) if defined $Success;
> ---
> >   if(defined $Success) {$status = $Success; last;}
> 
> All the best and keep up the MV spirit.
> 

Absolutely correct. I also fixed some other things I found
when I was checking validity of this. Basically, I should have
been returning 0 and not undef on the check routines.

Thanks Ton!

-- 
Internet Robotics, 131 Willow Lane, Floor 2, Oxford, OH  45056
phone +1.513.523.7621 fax 7501 <mikeh@minivend.com>

Clothes make the man.  Naked people have little or no influence on
society.  -- Mark Twain
-
To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list