[ic] 5.5.0 errors - bugs?

Peter peter at pajamian.dhs.org
Tue Oct 31 04:56:41 EST 2006


On 10/31/2006 01:44 AM, Kevin Walsh wrote:
> Peter <peter at pajamian.dhs.org> wrote:
>> Index: code/UI_Tag/version.coretag
>> ===================================================================
>> RCS file: /var/cvs/interchange/code/UI_Tag/version.coretag,v
>> retrieving revision 1.12
>> diff -u -p -r1.12 version.coretag
>> --- code/UI_Tag/version.coretag	8 Nov 2005 18:14:40 -0000	1.12
>> +++ code/UI_Tag/version.coretag	31 Oct 2006 01:26:11 -0000
>> @@ -22,8 +22,10 @@ sub {
>>  	}
>>
>>  	if($opt->{local_error}) {
>> -		my $fn = $Vend::Cfg->{ErrorFile};
>> -		push @out, $Tag->page("$::Variable->{UI_BASE}/do_view", $fn) . "$fn</a>";
>> +		my $dfn = my $fn = $Vend::Cfg->{ErrorFile};
>> +		my $pre = $Global::Catalog{$Vend::Cat}->{dir} . '/';
>> +		$fn =~ s:^\Q$pre\E::;
>> +		push @out, $Tag->page("$::Variable->{UI_BASE}/do_view", $fn) .
>> "$dfn</a>";
>>  		$done_something = 1;
>>  	}
>>
> Hello Peter.
> 
> If you commit that patch (and I think you should) can you change
> $Tag->page() to $Tag->area().
> 
>     my $href = $Tag->area("$::Variable->{UI_BASE}/do_view",$fn);
>     push(@out,"<a href="$href">$dfn</a>");
> 
> I just can't stand [page] and think it should slowly (or quickly) fade
> into oblivion. :-)


Yep, I was gonna commit it this evening when I had more time and I'll
take your advice and change it to area.

Peter


More information about the interchange-users mailing list