[ic] 5.5.0 errors - bugs?

Kevin Walsh kevin at cursor.biz
Tue Oct 31 05:37:17 EST 2006


Peter <peter at pajamian.dhs.org> wrote:
> On 10/31/2006 01:44 AM, Kevin Walsh wrote:
> > Peter <peter at pajamian.dhs.org> wrote:
> >> Index: code/UI_Tag/version.coretag
> >> ===================================================================
> >> RCS file: /var/cvs/interchange/code/UI_Tag/version.coretag,v
> >> retrieving revision 1.12
> >> diff -u -p -r1.12 version.coretag
> >> --- code/UI_Tag/version.coretag	8 Nov 2005 18:14:40 -0000	1.12
> >> +++ code/UI_Tag/version.coretag	31 Oct 2006 01:26:11 -0000
> >> @@ -22,8 +22,10 @@ sub {
> >>  	}
> >>
> >>  	if($opt->{local_error}) {
> >> -		my $fn = $Vend::Cfg->{ErrorFile};
> >> -		push @out, $Tag->page("$::Variable->{UI_BASE}/do_view", $fn) . "$fn</a>";
> >> +		my $dfn = my $fn = $Vend::Cfg->{ErrorFile};
> >> +		my $pre = $Global::Catalog{$Vend::Cat}->{dir} . '/';
> >> +		$fn =~ s:^\Q$pre\E::;
> >> +		push @out, $Tag->page("$::Variable->{UI_BASE}/do_view", $fn) .
> >> "$dfn</a>";
> >>  		$done_something = 1;
> >>  	}
> >>
> > Hello Peter.
> > 
> > If you commit that patch (and I think you should) can you change
> > $Tag->page() to $Tag->area().
> > 
> >     my $href = $Tag->area("$::Variable->{UI_BASE}/do_view",$fn);
> >     push(@out,"<a href="$href">$dfn</a>");
> > 
> > I just can't stand [page] and think it should slowly (or quickly) fade
> > into oblivion. :-)
> 
> 
> Yep, I was gonna commit it this evening when I had more time and I'll
> take your advice and change it to area.
> 
Looking at my proposed change, above, I have too many quotes in there.
Oops.  This is probably better (still untested):

    my $href = $Tag->area("$::Variable->{UI_BASE}/do_view",$fn);
    push(@out,qq{<a href="$href">$dfn</a>});

I'm sure you would have spotted that before committing, but I thought I
had better put my hands up and admit it anyway. :-)

-- 
   _/   _/  _/_/_/_/  _/    _/  _/_/_/  _/    _/
  _/_/_/   _/_/      _/    _/    _/    _/_/  _/   K e v i n   W a l s h
 _/ _/    _/          _/ _/     _/    _/  _/_/    kevin at cursor.biz
_/   _/  _/_/_/_/      _/    _/_/_/  _/    _/


More information about the interchange-users mailing list