[ic] [interchange] Fix for restrict_allow which was being clobbered by default values.

Peter peter at pajamian.dhs.org
Mon May 9 20:50:40 UTC 2016


On 10/05/16 01:23, Mike Heins wrote:
> Bottom line is that I don't see the benefit of having these 
> shadow values preserved by this code -- if you are setting 
> restrict_allow, you might as well add " area var " to it.
> 
> When I think about it, there is some question as to whether
> you might get unexplained behavior because you don't understand
> that "page area var" are not intrinsically allowed but are instead
> allowed via a default setting.  But if you know enough to do the
> setting, you should quickly be able to diagnose why your [var FOO] tag
> doesn't get interpolated.
> 
> Remember that you can set $opt with the tag call, too -- it is
> not always done via CGI. In the admin, especially.

Note also that someone may have explicitly wanted to override the
default values with the opt and now they can't due to this patch, so it
could very well break existing code.


Peter



More information about the interchange-users mailing list