[Date Prev][Date Next][Thread Prev][Thread Next][Minivend by date
][Minivend by thread
]
[mv] patch for test.pl in MV-alpha13 build (fixes server/control issue on BSD 3.1)
****** message to minivend-users from Mark Stosberg <mark@summersault.com> ******
On my FreeBSD 3.1 machine, 'make test' (after running just 'make') was
failing at the last step 'server/control'. Testing revealed that running
the same command directly on the command line produced no error. It
appeared that the command to quit minivend wasn't deleting the
minivend.pid file before the test.pl script checked to see if the pid
was still there.
So an error was reported although there wasn't actually a problem.
This could be a forking/process management issue in Minivend, or it
could be something unusual about my OS. The below patch for test.pl
simply causes the script to sleep for a second in between stopping the
server and checking for the file.
With this change MV alpha 13 passed "make test" on my FreeBSD 3.1 machine.
-mark
<<-------------------------------------------------------------->>
personal website < Summersault Website Design
http://mark.stosberg.com/ > http://www.summersault.com/
--- test.pl Fri Dec 10 14:07:42 1999
+++ test.pl.modified Sat Feb 5 11:15:42 2000
@@ -249,13 +249,14 @@
if ( system qq{$Config{'perlpath'} blib/script/minivend -q -stop} ) {
print "not ok $testnum\n";
$failed++;
-}
-elsif (-f 'blib/etc/minivend.pid') {
- print "not ok $testnum\n";
- $failed++;
-}
-else {
+}
+sleep 1;
+
+if (-f 'blib/etc/minivend.pid') {
+ print "not ok $testnum\n"
+ $failed++;
+} else {
print "ok $testnum\n";
}
$testnum++;
-
To unsubscribe from the list, DO NOT REPLY to this message. Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list