Akopia Akopia Services

[Date Prev][Date Next][Thread Prev][Thread Next][Minivend by date ][Minivend by thread ]

[mv] Bug in 4.04 expire (with fix)




I found a small cosmetic bug in bin/expire from minivend-4.04.

When using MySQL (or PGSQL for that matter), expire would give output like
this:

root@skippyii# sh ./expire.orig -r -c ci
HASH(0x8831324)Using MySQL for databases, DSN=dbi:mysql:ci_minivend.
root@skippyii#

This was because the logGlobal method in expire which overrides the one in
Util.pm couldn't handle the loglevel argument which various other routines
would pass to logGlobal.

The attached patch fixes the problem.

patch expire < expire-4.04-patch

--
Matthew Emmerton
Computer Partners
IT Specialist
*** expire.orig	Wed May 10 10:46:25 2000
--- expire	Wed May 10 10:46:18 2000
***************
*** 96,102 ****
  
  $Vend::Quiet = 1;
  
! sub logGlobal { warn(@_) }
  sub is_retired {}
  
  my $USAGE = <<EOF;
--- 95,108 ----
  
  $Vend::Quiet = 1;
  
! sub logGlobal { 
!   my($msg) = shift; 
!   if (ref $msg) {
!     $msg = shift;
!   }
!   warn($msg);
! }
! 
  sub is_retired {}
  
  my $USAGE = <<EOF;

Search for: Match: Format: Sort by: