Re: [mv] Bug in 4.04 expire (with fix)

[Mike Heins <mikeh@minivend.com>]

******    message to minivend-users from Mike Heins <mikeh@minivend.com>     ******

Quoting Matthew Emmerton (matt@skippyii.compar.com):
> 
> I found a small cosmetic bug in bin/expire from minivend-4.04.
> 
> When using MySQL (or PGSQL for that matter), expire would give output like
> this:
> 
> root@skippyii# sh ./expire.orig -r -c ci
> HASH(0x8831324)Using MySQL for databases, DSN=dbi:mysql:ci_minivend.
> root@skippyii#
> 
> This was because the logGlobal method in expire which overrides the one in
> Util.pm couldn't handle the loglevel argument which various other routines
> would pass to logGlobal.
> 
> The attached patch fixes the problem.
> 

Yes, indeed. Thanks for the patch. I actually made this to the fix for
4.05:

    use Vend::Util qw/errmsg/;

    sub logGlobal {
	ref $_[0] and shift(@_);
	warn(errmsg(@_));
    }

That handles the new MV error message format where you might be passing
a format string with parameters.

I love getting fixes!

Best,
Mike
-- 
Internet Robotics, 131 Willow Lane, Floor 2, Oxford, OH  45056
phone +1.513.523.7621 fax 7501 <mikeh@minivend.com>

Just because something is obviously happening doesn't mean something
obvious is happening. --Larry Wall
-
To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list